Adding PPN photolysis #2371

bexhorner · 2024-07-11T12:00:58Z

Name and Institution (Required)

Name: Bex Horner, @eamarais
Institution: University College London (UCL)

Describe the update

This update adds the PPN photolysis reaction to KPP as outlined in Horner et al. (2024).

PAN + OH and PPN + OH reactions are added using the structure-activity relationship approach.

The maximum number of J-values is increased to account for PPN photolysis.

Expected changes

NO2 concentrations will increase in the upper troposphere by ~30-60 pptv where PPN is abundant and thermally stable.

Reference(s)

Horner et al. 2024. "Vertical profiles of global tropospheric nitrogen dioxide (NO2) obtained via cloud-slicing" (https://doi.org/10.5194/egusphere-2024-1541)

yantosca

Thanks @bexhorner for this update. I have a couple of comments:

Can you remove the .DS_Store file? This is a binary file, and we try to avoid adding those to Git repos. See this link for more info on how to delete a file from a PR: https://stackoverflow.com/questions/9498201/delete-file-from-pull-request-on-github/9498304#9498304
Would you be able add a note to the KPP/fullchem/CHANGELOG_fullchem.md about this update?
Can you add the same updates in KPP/fullchem/fullchem.eqn to KPP/custom/custom.eqn? We try to keep these synchronized.

Thanks!

yantosca

Thanks @bexhorner! We can try to get this into 14.5.0.

lizziel · 2024-07-11T15:05:03Z

According to geoschem/Cloud-J#21, this update will also require updates to input files FJX_j2j.dat and FJX_spec.dat. I am going to close that PR since the updates should go into a new folder in the Cloud-J directory of ExtData/CHEM_INPUTS rather than the Cloud-J example tables.

@bexhorner, could you post the FJX_j2j.dat and FJX_spec.dat files are you using for your testing? If you add extension .txt you can drag and drop them into the GitHub comment box on this page.

bexhorner · 2024-07-11T15:18:13Z

@lizziel

FJX_j2j.txt
FJX_spec.txt

lizziel · 2024-07-11T15:47:36Z

Headers/CMN_FJX_MOD.F90

@@ -31,7 +31,7 @@ MODULE CMN_FJX_MOD
  ! Parameters
  !-----------------------------------------------------------------------

-  INTEGER, PARAMETER :: JVN_ = 166     ! Max number of J-values
+  INTEGER, PARAMETER :: JVN_ = 167     ! Max number of J-values


This will only apply when running with FAST-JX, which is non-default except for the mercury simulation. Currently the max number of J-values is hard-coded in Cloud-J. Restructuring the memory is on the todo list so that we can instead pass it from the parent model.

Could you confirm that your tests used FAST-JX rather than Cloud-J? If using Cloud-J then this line needs to change: https://github.com/geoschem/Cloud-J/blob/03313bb6acde16a9962c3a5e18a3f78b4d220faa/src/Core/cldj_cmn_mod.F90#L47

This update is no longer needed because of a feature I added to Cloud-J where JVN_ is truly the max # of J-values rather than the exact number of entries in FJX_j2j.dat. I updated the value of 200 to be above what we actually need. geoschem/Cloud-J#26

eamarais · 2024-07-11T15:55:30Z

yeah, @lizziel, changes were made with FAST-JX, so our updates will be missing changes specific to CLOUD-J.

lizziel · 2024-07-11T17:28:21Z

Okay, so the input files provided were not used for testing. They appear to be modifications of the Cloud-J tables files which do not include all GEOS-Chem species. We can look at the changes only and create Cloud-J input files that would work.

bexhorner · 2024-07-12T09:59:02Z

@lizziel so the changes were made using FAST-JX and tested using the files below. The files I sent previously were applying the modifications used here to the Cloud-J tables.

FJX_j2j.txt
FJX_spec.txt

yantosca · 2024-08-20T20:57:59Z

@lizziel has created updated configuration files for PPN photolysis in ExtData/CHEM_Inputs/Cloud_J/v2024-08.

Also note, we will merge this following PR #2426.

yantosca · 2024-08-28T18:26:40Z

After rebasing on top of PR #2428, all GCHP integration tests pass:

==============================================================================
GCHP: Execution Test Results

CodeDir       : da8ea12 GEOS-Chem submod update: Merge PR #2428 (vdiff) and PR #2144 (drydep)
MAPL          : 231d53c Merge pull request #36 from geoschem/feature/improve_hflux_regridding
GMAO_Shared   : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake    : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared   : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS           : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem     : 99f1cf9c9 Rebuild chemical mechanism for PPN photolysis w/ KPP 3.1.1
HEMCO         : d0d5fca PR #285 post-merge fix: Update CHANGELOG.md
yaFyaml       : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger      : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J       : d20050f Update version to 7.7.3
HETP          : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Number of execution tests: 12

Submitted as SLURM job: 45330505
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

yantosca · 2024-08-28T18:33:51Z

All GEOS-Chem Classic tests also passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

CodeDir   : 153a355 GEOS-Chem submod update: Merge PR #2428 (vdiff) and PR #2144 (drydep)
GEOS-Chem : 99f1cf9c9 Rebuild chemical mechanism for PPN photolysis w/ KPP 3.1.1
HEMCO     : d0d5fca PR #285 post-merge fix: Update CHANGELOG.md
Cloud-J   : d20050f Update version to 7.7.3
HETP      : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Using 24 OpenMP threads
Number of execution tests: 30

Submitted as SLURM job: 45327972
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

yantosca · 2024-08-29T17:52:30Z

This PR was integration-tested with PR #2436 and PR #2439. All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

CodeDir   : 153a355 GEOS-Chem submod update: Merge PR #2428 (vdiff) and PR #2144 (drydep)
GEOS-Chem : d34c567a4 Merge PR #2436 (Update GFED4 climatology for 2010-2023)
HEMCO     : d0d5fca PR #285 post-merge fix: Update CHANGELOG.md
Cloud-J   : d20050f Update version to 7.7.3
HETP      : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Using 24 OpenMP threads
Number of execution tests: 30

Submitted as SLURM job: 45504789
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

yantosca · 2024-08-29T18:19:19Z

This PR was integration-tested with PR #2436 and PR #2439. All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

CodeDir       : da8ea12 GEOS-Chem submod update: Merge PR #2428 (vdiff) and PR #2144 (drydep)
MAPL          : 231d53c Merge pull request #36 from geoschem/feature/improve_hflux_regridding
GMAO_Shared   : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake    : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared   : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS           : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem     : d34c567a4 Merge PR #2436 (Update GFED4 climatology for 2010-2023)
HEMCO         : d0d5fca PR #285 post-merge fix: Update CHANGELOG.md
yaFyaml       : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger      : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J       : d20050f Update version to 7.7.3
HETP          : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Number of execution tests: 12

Submitted as SLURM job: 45515705
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@bexhorner

This merge brings PR #2371 (Adding PPN photolysis, by @bexhorner) into the GEOS-Chem 14.5.0 development stream. This PR adds photolysis rxns for the PPN species. Signed-off-by: Bob Yantosca <[email protected]>

run/shared/species_database.yml - Add "Is_Photolysis: true" YAML tag for PPN. We had omitted this from PR #2371. CHANGELOG.md - Updated accordingly. Signed-off-by: Bob Yantosca <[email protected]>

yantosca · 2024-09-05T14:42:49Z

@bexhorner @eamarais: Due to an oversight, we didn't properly update the FJX_j2j.dat. Will correct this as 14.5.0-alpha.10.

yantosca · 2024-09-06T21:19:13Z

We can now close this PR as it has been merged into the GEOS-Chem 14.5.0 development stream.

bexhorner added 3 commits July 10, 2024 17:46

Increasing the maximum number of J-values to account for PPN photolysis

93d964d

Adding PPN photolysis to KPP

5d061cd

Adding PPN photolysis to KPP

9c19e0e

bexhorner mentioned this pull request Jul 11, 2024

Add PPN photolysis rate and cross sections geoschem/Cloud-J#21

Closed

yantosca self-requested a review July 11, 2024 13:35

yantosca self-assigned this Jul 11, 2024

yantosca added topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms category: Feature Request New feature or request labels Jul 11, 2024

yantosca requested a review from lizziel July 11, 2024 13:39

yantosca requested changes Jul 11, 2024

View reviewed changes

Adding PPN photolysis to KPP

297426f

yantosca approved these changes Jul 11, 2024

View reviewed changes

lizziel requested changes Jul 11, 2024

View reviewed changes

This was referenced Jul 12, 2024

Throw a CMake error if FAST-JX is used for any KPP mechanism except Hg geoschem/GCClassic#62

Merged

Throw a CMake error if FAST-JX is used for any KPP mechanism except Hg geoschem/GCHP#426

Closed

yantosca added this to the 14.5.0 milestone Aug 28, 2024

This was referenced Aug 29, 2024

Update run scripts and environment files for NASA discover cluster #2439

Merged

Update GFED4_Climatology entries for period 2010-2023 with new species #2436

Merged

msulprizio changed the base branch from main to dev/14.5.0 September 3, 2024 15:24

yantosca mentioned this pull request Sep 5, 2024

Bug fix: Reorder photo rxns for PNs and ANs (from PR #2318) #2452

Merged

yantosca closed this Sep 6, 2024

yantosca mentioned this pull request Sep 10, 2024

Inconsistencies between photolysis species listed in species_database.yml and FJX_j2j.dat for fullchem mechanism #2456

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding PPN photolysis #2371

Adding PPN photolysis #2371

bexhorner commented Jul 11, 2024

yantosca left a comment

yantosca left a comment

lizziel commented Jul 11, 2024 •

edited

Loading

bexhorner commented Jul 11, 2024 •

edited

Loading

lizziel Jul 11, 2024 •

edited

Loading

lizziel Sep 4, 2024 •

edited

Loading

eamarais commented Jul 11, 2024

lizziel commented Jul 11, 2024

bexhorner commented Jul 12, 2024

yantosca commented Aug 20, 2024

yantosca commented Aug 28, 2024

yantosca commented Aug 28, 2024

yantosca commented Aug 29, 2024

yantosca commented Aug 29, 2024

yantosca commented Sep 5, 2024

yantosca commented Sep 6, 2024

Adding PPN photolysis #2371

Adding PPN photolysis #2371

Conversation

bexhorner commented Jul 11, 2024

Name and Institution (Required)

Describe the update

Expected changes

Reference(s)

yantosca left a comment

Choose a reason for hiding this comment

yantosca left a comment

Choose a reason for hiding this comment

lizziel commented Jul 11, 2024 • edited Loading

bexhorner commented Jul 11, 2024 • edited Loading

lizziel Jul 11, 2024 • edited Loading

Choose a reason for hiding this comment

lizziel Sep 4, 2024 • edited Loading

Choose a reason for hiding this comment

eamarais commented Jul 11, 2024

lizziel commented Jul 11, 2024

bexhorner commented Jul 12, 2024

yantosca commented Aug 20, 2024

yantosca commented Aug 28, 2024

yantosca commented Aug 28, 2024

yantosca commented Aug 29, 2024

yantosca commented Aug 29, 2024

yantosca commented Sep 5, 2024

yantosca commented Sep 6, 2024

lizziel commented Jul 11, 2024 •

edited

Loading

bexhorner commented Jul 11, 2024 •

edited

Loading

lizziel Jul 11, 2024 •

edited

Loading

lizziel Sep 4, 2024 •

edited

Loading